Port some more truncation check related code #1373
Merged
+168
−88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Ports additional truncation-check features and refactors type-to-string logic, while updating submodule compiler snapshots.
- Refactors
mapToTypeNodesto support truncation flags and adds corresponding truncation handling. - Switches from
typeToStringExto a simplertypeToStringhelper and replacesvisitedTypesmap withcollections.Set. - Updates submodule compiler baselines for namespace disambiguation and computed-name declaration emit tests, and adds AST pooling for intersection-type nodes.
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| internal/collections/multimap.go | Added Values() method to MultiMap |
| internal/checker/relater.go | Replaced typeToStringEx calls with typeToString |
| internal/checker/printer.go | Introduced typeToString helper and updated TypeToString |
| internal/checker/nodebuilderimpl.go | Refactored mapToTypeNodes, added truncation logic, changed visitedTypes type |
| internal/checker/nodebuilder.go | Removed visitedTypes map initialization |
| internal/ast/ast.go | Added pooling support for IntersectionTypeNode |
| testdata/baselines/reference/submodule/compiler/namespaceDisambiguationInUnion.errors.txt | Updated expected error messages |
| testdata/baselines/reference/submodule/compiler/declarationEmitSimpleComputedNames1.js | Fixed computed-names declaration emit baselines |
| testdata/baselines/reference/submodule/compiler/declarationEmitClassMemberWithComputedPropertyName.js | Adjusted computed-property declaration emit baselines |
Comments suppressed due to low confidence (3)
internal/checker/nodebuilder.go:28
- The
visitedTypesSet field is never initialized inenterContext, leading to nil-pointer panics when calling.Hasor.Add. Initialize it, e.g.,visitedTypes: collections.NewSet[TypeId](),.
inferTypeParameters: make([]*Type, 0),
internal/collections/multimap.go:63
- Consider adding unit tests for the new
Valuesmethod to verify it returns the expected sequence of value slices.
func (s *MultiMap[K, V]) Values() iter.Seq[[]V] {
internal/checker/nodebuilderimpl.go:242
- Calling
fmt.Sprintfhere requires importing thefmtpackage. Addimport "fmt"to the file's import block.
text := fmt.Sprintf("... %d more ...", len(list)-2)
jakebailey
commented
Jul 11, 2025
|
|
||
| if b.checkTruncationLength() { | ||
| if !isBareList { | ||
| var node *ast.Node |
There was a problem hiding this comment.
This entire block is unused per codecov, so not sure what the deal is there; it might not even be used in Strada
There was a problem hiding this comment.
I think it's triggered by some LS tests in Strada? I vaguely remember adding this truncation check (along with the hard cut at the top level) in response to an LS request freezing the editor with a 50MB hover.
weswigham
approved these changes
Jul 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are things I found while trying to work through #988.